Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recycling of implicit tax from BECCS qtty target in regipol #1745

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Jul 15, 2024

Purpose of this PR

  • I forgot that in add BECCS qtty target to regipol #1336, where I adapted only postsolve and presolve. Now, apply the same code change to equations.gms
  • lead to non-convergence in various integrated damage runs based on Kotz-Wenz damage function, and d_delfrag NGFS run

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test): [ FAIL 0 | WARN 0 | SKIP 6 | PASS 83 ]
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters force-pushed the beccslimit branch 4 times, most recently from ea07ee4 to f4c60d1 Compare July 15, 2024 08:57
@orichters orichters marked this pull request as ready for review July 15, 2024 10:21
@orichters orichters marked this pull request as draft July 17, 2024 08:12
@orichters
Copy link
Contributor Author

orichters commented Jul 17, 2024

Ok, that does not work at all.

      + sum((emiMkt,entySe,secInd37,entyFe)$entySeBio(entySe), pm_IndstCO2Captured(t,regi,entySe,entyFe,secInd37,emiMkt))
      ) * pm_share_CCS_CCO2(t,regi) )$(sameas(qttyTarget,"CCS") AND sameas(qttyTargetGroup,"biomass"))

does not contain variables, but just things that are updated in postsolve only. So you basically add and substract the exact same value, thus the tax has no effect at all in this case. Would probably mean turning pm_IndstCO2Captured into some sort of variable.

And somehow I just implemented the recycling, not the tax itself. Why the hell did that work at all?

)$(sameas(qttyTarget,"CCS") AND sameas(qttyTargetGroup,"all"))
+
(( !! Supply side BECCS
sum(emiBECCS2te(enty,enty2,te,enty3),vm_emiTeDetail.l(t,regi,enty,enty2,te,enty3))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to remove the .l here so the model knows there is a trade-off between the tax and the level of vm_emiTeDetail here.

(( !! Supply side BECCS
sum(emiBECCS2te(enty,enty2,te,enty3),vm_emiTeDetail.l(t,regi,enty,enty2,te,enty3))
!! Industry BECCS (using biofuels in Industry with CCS)
+ sum((emiMkt,entySe,secInd37,entyFe)$entySeBio(entySe), pm_IndstCO2Captured(t,regi,entySe,entyFe,secInd37,emiMkt))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to consider the industry BECCS tradeoff, you should replace the parameters calculated in the postsolve by the variables used to calculate them.
However this will be most probably a quite non-linear equation, and I am not sure how big is the importance of the industry BECCS in the target you want to achieve.

@orichters orichters force-pushed the beccslimit branch 3 times, most recently from a255294 to aaf2ffc Compare July 19, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants