Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All enty split #951

Open
wants to merge 57 commits into
base: develop
Choose a base branch
from
Open

All enty split #951

wants to merge 57 commits into from

Conversation

chroetz
Copy link
Contributor

@chroetz chroetz commented Aug 24, 2022

Purpose of this PR

updated version of #500:

This PR is the first part of the refactoring of the all_enty from Remind. Replacing this set step by step improves readability and makes it more clear which part of the set is actually used in equations, parameters and variables.
In the first step a report was generated which contains all variables,parameters and equations, depending on all_enty, but actually only in a subset form from the set emiTe. This report can be found here:
emiTeReport.csv

Afterwards all occurrences of these variables where located in the remind folder and replaced with emiTe instead of all_enty. After each replacement a testOneRegi run was performed to check if simulation results alter. After all possible variables were renamed, SSP and policy runs where executed to check the simulation results even more carefully.
There are changes between the develop and the emiTe runs, please review them carefully.

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I have performed a self-review of my own code
  • Changes are commented, particularly in hard-to-understand areas
  • I have updated the in-code documentation
  • I have adjusted reporting where it was needed
  • The model compiles and runs successfully (Rscript start.R -q)

Further information:

  • Test runs are here: /p/tmp/cschoetz/allEntySplit/remind/output/V1-end-Base_2022-08-23_18.34.47

Mike Spahr and others added 30 commits August 27, 2021 09:33
…ly depending on emiTe. No changes in testOneRegi
…demand, o_emissions_energy_supply_gross, o_emissions_energy_supply_gross_carrier s all_enty to emiTe. No changes in testOneRegi
spahrm and others added 25 commits October 1, 2021 13:49
adds changes of old all_enty split. Not really sure whether the merge conflicts were resolved correctly
@chroetz chroetz marked this pull request as ready for review August 25, 2022 09:53
@@ -1822,9 +1822,19 @@ entyFeTrans(all_enty) "final energy types from transport sector"

feForCes(all_enty) "limit q_balFeForCes to entyFe in fe2ppfEn"

emi(all_enty) "types of emissions, these emissions are given to the climate module"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did I miss the deletion of emission entities from the all_enty-set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants