-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All enty split #951
Open
chroetz
wants to merge
57
commits into
remindmodel:develop
Choose a base branch
from
chroetz:allEntySplit
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
All enty split #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly depending on emiTe. No changes in testOneRegi
…. No changes in testOneRegi
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…demand, o_emissions_energy_supply_gross, o_emissions_energy_supply_gross_carrier s all_enty to emiTe. No changes in testOneRegi
…No changes in testOneRegi
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
…feature/oneByOne_all_enty
adds changes of old all_enty split. Not really sure whether the merge conflicts were resolved correctly
Old all enty split
update all enty split
update all enty split
chroetz
requested review from
LaviniaBaumstark,
Renato-Rodrigues and
robertpietzcker
August 25, 2022 09:53
@@ -1822,9 +1822,19 @@ entyFeTrans(all_enty) "final energy types from transport sector" | |||
|
|||
feForCes(all_enty) "limit q_balFeForCes to entyFe in fe2ppfEn" | |||
|
|||
emi(all_enty) "types of emissions, these emissions are given to the climate module" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did I miss the deletion of emission entities from the all_enty-set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
updated version of #500:
Type of change
Checklist:
Rscript start.R -q
)Further information:
/p/tmp/cschoetz/allEntySplit/remind/output/V1-end-Base_2022-08-23_18.34.47