filtering devices by serial number

[carlodri]

Hello, and thanks for the great package!

I am trying to filter HID devices by serial number, using the following code:

filter = hid.HidDeviceFilter(vendor_id=0x2047, product_id=0x0965, serial_number = '123456')
devices_found = filter.get_devices()

The problem I'm facing is that the filter seems to ignore the serial_number = '123456' constraint, i.e. whatever string I put in the serial_number argument the list of devices is always the same. Is this a bug or am I missing something?

I can obviously filter the list manually, but I would have preferred to use the built-in filter...

[carlodri]

ok I think I answered myself about this, the problem is here:

pywinusb/pywinusb/hid/core.py

Lines 259 to 260 in 954c4b2

	filter_attributes = ["vendor_id", "product_id", "version_number",
	"product_name", "vendor_name"]

and here:

pywinusb/pywinusb/hid/core.py

Lines 220 to 221 in 954c4b2

	elif item not in HidDevice.filter_attributes:
	continue # field does not exist sys.error.write(...)

It seems like the filtering capability is restricted to the fields listed above in filter_attributes. Il will try and see if that list can be extended.