Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG FIX: Make sure %dorng% works also when 'foreach' is not attached #19

Closed
wants to merge 0 commits into from
Closed

BUG FIX: Make sure %dorng% works also when 'foreach' is not attached #19

wants to merge 0 commits into from

Conversation

HenrikBengtsson
Copy link

BUG FIX: Make sure %dorng% works also when 'foreach' is not attached (fix #18)

Secured also two other do.call() instances that called a function by string rather than by function object

@HenrikBengtsson HenrikBengtsson mentioned this pull request Nov 24, 2020
Open
@renozao
Copy link
Owner

renozao commented Nov 27, 2020 •
edited
Loading

@HenrikBengtsson Thanks for this PR. I'll merge it.
Wondering why this was not working:

  • foreach is in Depends
  • I import the whole package in the NAMESPACE with import(foreach)

Is it that calling do.call() with a string lookup for the function in the incorrect place?

@renozao
Copy link
Owner

renozao commented Nov 27, 2020

@HenrikBengtsson can you please make the PR against branch develop, where I have made edits to solve Travis CI issues.
Any chance we can get a unit-test for this? I guess it will need to run the code you put in the issue within a separate Rscript session to ensure a clean initial state of the loaded packages.

@HenrikBengtsson HenrikBengtsson mentioned this pull request Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

%dorng% does not work unless the 'foreach' package is attached
2 participants
@HenrikBengtsson @renozao