From 710df616daac5a11c5a794e0af706c9b077cdd4f Mon Sep 17 00:00:00 2001 From: Salah Al Saleh Date: Wed, 15 May 2024 06:37:56 -0700 Subject: [PATCH] Upload support bundles as GH artifacts (#4621) --- .../generate-support-bundle/action.yml | 30 +++---- .github/actions/kots-e2e/action.yml | 16 +--- .github/workflows/build-test.yaml | 84 ++++--------------- e2e/playwright/tests/smoke-test/test.spec.ts | 2 +- 4 files changed, 36 insertions(+), 96 deletions(-) diff --git a/.github/actions/generate-support-bundle/action.yml b/.github/actions/generate-support-bundle/action.yml index 68628abf3f..ba87c2661f 100644 --- a/.github/actions/generate-support-bundle/action.yml +++ b/.github/actions/generate-support-bundle/action.yml @@ -1,27 +1,17 @@ name: 'Generate Support Bundle' description: 'Composite action for generating a support bundle' inputs: - aws-access-key-id: - description: 'AWS access key id for uploading support bundle' + artifact-name: + description: 'Name of the artifact to be uploaded' required: true - aws-secret-access-key: - description: 'AWS secret access key for uploading support bundle' - required: true - aws-region: - description: 'AWS region for uploading support bundle' - default: 'us-east-1' - required: false kots-namespace: description: 'KOTS namespace' required: true runs: using: "composite" steps: - - name: Generate support bundle on failure + - id: generate-support-bundle env: - AWS_ACCESS_KEY_ID: ${{ inputs.aws-access-key-id }} - AWS_SECRET_ACCESS_KEY: ${{ inputs.aws-secret-access-key }} - AWS_DEFAULT_REGION: ${{ inputs.aws-region }} KOTS_NAMESPACE: ${{ inputs.kots-namespace }} run: | RELEASE="$( @@ -33,6 +23,16 @@ runs: tar xzf support-bundle_linux_amd64.tar.gz ./support-bundle https://kots.io BUNDLE="$(ls -1 | grep 'support-bundle-.*.tar.gz')" - aws s3 cp "${BUNDLE}" "s3://kots-e2e-build-test-support-bundles/${BUNDLE}" - echo "::notice ::support bundle uploaded to aws replicated-dev account s3://kots-e2e-build-test-support-bundles/${BUNDLE}" + echo "bundle-name=$BUNDLE" >> "$GITHUB_OUTPUT" + shell: bash + + - id: upload-support-bundle + uses: actions/upload-artifact@v4 + with: + name: ${{ inputs.artifact-name }} + path: ${{ steps.generate-support-bundle.outputs.bundle-name }} + + - name: Print support bundle URL shell: bash + run: | + echo "::notice ::support bundle can be downloaded from: ${{ steps.upload-support-bundle.outputs.artifact-url }}" diff --git a/.github/actions/kots-e2e/action.yml b/.github/actions/kots-e2e/action.yml index 5330c44d69..33e185b0b7 100644 --- a/.github/actions/kots-e2e/action.yml +++ b/.github/actions/kots-e2e/action.yml @@ -60,16 +60,6 @@ inputs: description: 'Run KOTS with the --airgap flag' default: "false" required: false - aws-access-key-id: - description: 'AWS access key id for uploading support bundle' - required: false - aws-secret-access-key: - description: 'AWS secret access key for uploading support bundle' - required: false - aws-region: - description: 'AWS region for uploading support bundle' - default: 'us-east-1' - required: false replicated-api-token: description: 'Replicated API token for C11y matrix' required: false @@ -171,12 +161,10 @@ runs: shell: bash - name: Generate support bundle on failure - if: ${{ failure() && inputs.aws-access-key-id && inputs.aws-secret-access-key }} + if: ${{ failure() }} uses: ./.github/actions/generate-support-bundle with: - aws-access-key-id: ${{ inputs.aws-access-key-id }} - aws-secret-access-key: ${{ inputs.aws-secret-access-key }} - aws-region: ${{ inputs.aws-region }} + artifact-name: ${{ github.job }}-${{ inputs.k8s-distribution }}-${{ inputs.k8s-version }}-support-bundle - name: Remove Cluster id: remove-cluster diff --git a/.github/workflows/build-test.yaml b/.github/workflows/build-test.yaml index dc0d930b57..240858785e 100644 --- a/.github/workflows/build-test.yaml +++ b/.github/workflows/build-test.yaml @@ -597,8 +597,6 @@ jobs: k8s-version: v1.26 testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -635,8 +633,6 @@ jobs: k8s-distribution: ${{ matrix.cluster.distribution }} k8s-version: ${{ matrix.cluster.version }} k8s-instance-type: ${{ matrix.cluster.instance_type }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -741,8 +737,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -785,8 +780,6 @@ jobs: k8s-distribution: ${{ matrix.cluster.distribution }} k8s-version: ${{ matrix.cluster.version }} k8s-instance-type: ${{ matrix.cluster.instance_type }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -823,8 +816,6 @@ jobs: kots-namespace: 'no-required-config' k8s-distribution: ${{ matrix.cluster.distribution }} k8s-version: ${{ matrix.cluster.version }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -926,8 +917,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -970,8 +960,6 @@ jobs: kots-namespace: 'config-validation' k8s-distribution: ${{ matrix.cluster.distribution }} k8s-version: ${{ matrix.cluster.version }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -1010,8 +998,6 @@ jobs: k8s-version: ${{ matrix.cluster.version }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -1049,8 +1035,6 @@ jobs: k8s-version: ${{ matrix.cluster.version }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -1218,8 +1202,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -1330,8 +1313,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -1440,8 +1422,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_NAME" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -1598,8 +1579,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -1696,8 +1676,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -1818,8 +1797,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -1955,8 +1933,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -2171,8 +2148,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: automated-${{ github.run_id }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -2224,8 +2200,6 @@ jobs: testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} kotsadm-image-registry: ttl.sh - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -2291,8 +2265,6 @@ jobs: k8s-version: ${{ matrix.cluster.version }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -2358,8 +2330,6 @@ jobs: k8s-version: ${{ matrix.cluster.version }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -2517,8 +2487,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -2704,8 +2673,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -2750,8 +2718,6 @@ jobs: k8s-version: ${{ matrix.cluster.version }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -2790,8 +2756,6 @@ jobs: k8s-version: ${{ matrix.cluster.version }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -2831,8 +2795,6 @@ jobs: testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} kots-airgap: true - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -3004,8 +2966,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -3099,8 +3060,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -3325,8 +3285,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -3493,8 +3452,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -3803,8 +3761,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster @@ -3850,8 +3807,6 @@ jobs: k8s-version: ${{ matrix.cluster.version }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -3890,8 +3845,6 @@ jobs: k8s-version: ${{ matrix.cluster.version }} testim-access-token: '${{ secrets.TESTIM_ACCESS_TOKEN }}' testim-branch: ${{ github.head_ref == 'main' && 'master' || github.head_ref }} - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' replicated-api-token: '${{ secrets.C11Y_MATRIX_TOKEN }}' kots-dockerhub-username: '${{ secrets.E2E_DOCKERHUB_USERNAME }}' kots-dockerhub-password: '${{ secrets.E2E_DOCKERHUB_PASSWORD }}' @@ -4100,8 +4053,7 @@ jobs: uses: ./.github/actions/generate-support-bundle with: kots-namespace: "$APP_SLUG" - aws-access-key-id: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_ACCESS_KEY_ID }}' - aws-secret-access-key: '${{ secrets.E2E_SUPPORT_BUNDLE_AWS_SECRET_ACCESS_KEY }}' + artifact-name: ${{ github.job }}-${{ matrix.cluster.distribution }}-${{ matrix.cluster.version }}-support-bundle - name: Remove Cluster id: remove-cluster diff --git a/e2e/playwright/tests/smoke-test/test.spec.ts b/e2e/playwright/tests/smoke-test/test.spec.ts index bb9356c793..41f9d33523 100644 --- a/e2e/playwright/tests/smoke-test/test.spec.ts +++ b/e2e/playwright/tests/smoke-test/test.spec.ts @@ -181,7 +181,7 @@ test('smoke test', async ({ page }) => { await expect(page.getByLabel('Modal')).toContainText('Delete snapshot'); await page.getByRole('button', { name: 'Delete snapshot' }).click(); await expect(page.locator('#app')).toContainText('Deleting'); - await expect(page.locator('#app')).toContainText('No snapshots yet', { timeout: 15000 }); + await expect(page.locator('#app')).toContainText('No snapshots yet', { timeout: 30000 }); await page.getByRole('link', { name: 'Settings & Schedule' }).click(); await page.getByRole('button', { name: 'Update storage settings' }).click(); await expect(page.locator('form')).toContainText('Settings updated', { timeout: 30000 });