Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-deploy when installing an app is blocked by warnings in the preflight checks #847

Open
sgalsaleh opened this issue Jul 24, 2020 · 2 comments

Comments

@sgalsaleh
Copy link
Member

there are two proposals for handling this:

1- just ignore any warning level checks and only block on errors
2- allow a flag to bypass, for example --ignore-preflight-warnings

@markpundsack
Copy link
Contributor

IMHO, warnings should not block unattended installations. I was surprised when we blocked web installations for warnings, but understand the decision since it's just a confirmation away. But with unattended, the same is not true. I'm against adding a flag to bypass since then we teach users to just bypass warnings anyway, and at some point there will be a real warning they shouldn't have ignored. If we had a way to ignore specific warnings, that would be different, but that's a lot more complicated of a solution that isn't worth it.

@marccampbell pointed out that our docs to explicitly mention passing:

Once this has completed, visiting http://localhost:8800 will show the configured application dashboard, assuming all required config items were set and any included preflight checks passed.

But looking at the docs, in colloquial English, warnings are passed. In GitLab, for example, CI jobs show as “passed with warnings”. If I were running a CLI, the exit code for a command would be “success” even if there were warnings.

@austinchambers
Copy link
Contributor

We should consider allowing the same capability on errors as well (e.g., --ignore-preflight-errors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants