Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize valid domain checking #7

Open
abedra opened this issue Sep 3, 2018 · 0 comments
Open

Optimize valid domain checking #7

abedra opened this issue Sep 3, 2018 · 0 comments

Comments

@abedra
Copy link
Member

abedra commented Sep 3, 2018

Right now there's a disconnect against understanding if a user agent identifies as a bot and the validation being done to see if it is real. This is causing the validation to loop through all possible valid domains. It's currently only a negligible performance hit because there's a small number of domains, but this is still a poor design. The identification should select the provider that it identifies to maximize the efficiency of the validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant