diff --git a/crates/store/re_chunk/src/chunk.rs b/crates/store/re_chunk/src/chunk.rs index 25ace6e31545e..0d39331121db5 100644 --- a/crates/store/re_chunk/src/chunk.rs +++ b/crates/store/re_chunk/src/chunk.rs @@ -67,8 +67,6 @@ impl ChunkComponents { component_desc: ComponentDescriptor, list_array: Arrow2ListArray, ) -> Option> { - // TODO(cmc): revert me - let component_desc = component_desc.untagged(); self.0 .entry(component_desc.component_name) .or_default() diff --git a/docs/snippets/all/descriptors/descr_builtin_archetype.rs b/docs/snippets/all/descriptors/descr_builtin_archetype.rs index 5562420b50ccc..48ddffd25d5ad 100644 --- a/docs/snippets/all/descriptors/descr_builtin_archetype.rs +++ b/docs/snippets/all/descriptors/descr_builtin_archetype.rs @@ -56,24 +56,6 @@ fn check_tags(rec: &rerun::RecordingStream) { .collect::>(); descriptors.sort(); - // TODO(cmc): revert me - // let expected = vec![ - // ComponentDescriptor { - // archetype_name: None, - // archetype_field_name: None, - // component_name: "rerun.components.Points3DIndicator".into(), - // }, - // ComponentDescriptor { - // archetype_name: Some("rerun.archetypes.Points3D".into()), - // archetype_field_name: Some("positions".into()), - // component_name: "rerun.components.Position3D".into(), - // }, - // ComponentDescriptor { - // archetype_name: Some("rerun.archetypes.Points3D".into()), - // archetype_field_name: Some("radii".into()), - // component_name: "rerun.components.Radius".into(), - // }, - // ]; let expected = vec![ ComponentDescriptor { archetype_name: None, @@ -81,13 +63,13 @@ fn check_tags(rec: &rerun::RecordingStream) { component_name: "rerun.components.Points3DIndicator".into(), }, ComponentDescriptor { - archetype_name: None, - archetype_field_name: None, + archetype_name: Some("rerun.archetypes.Points3D".into()), + archetype_field_name: Some("positions".into()), component_name: "rerun.components.Position3D".into(), }, ComponentDescriptor { - archetype_name: None, - archetype_field_name: None, + archetype_name: Some("rerun.archetypes.Points3D".into()), + archetype_field_name: Some("radii".into()), component_name: "rerun.components.Radius".into(), }, ]; diff --git a/docs/snippets/all/descriptors/descr_custom_archetype.rs b/docs/snippets/all/descriptors/descr_custom_archetype.rs index f9804b0f1280c..83cab7434ce6b 100644 --- a/docs/snippets/all/descriptors/descr_custom_archetype.rs +++ b/docs/snippets/all/descriptors/descr_custom_archetype.rs @@ -104,38 +104,20 @@ fn check_tags(rec: &rerun::RecordingStream) { .collect::>(); descriptors.sort(); - // TODO(cmc): revert me - // let expected = vec![ - // ComponentDescriptor { - // archetype_name: None, - // archetype_field_name: None, - // component_name: "user.CustomPoints3DIndicator".into(), - // }, - // ComponentDescriptor { - // archetype_name: Some("user.CustomPoints3D".into()), - // archetype_field_name: Some("colors".into()), - // component_name: "rerun.components.Color".into(), - // }, - // ComponentDescriptor { - // archetype_name: Some("user.CustomPoints3D".into()), - // archetype_field_name: Some("custom_positions".into()), - // component_name: "user.CustomPosition3D".into(), - // }, - // ]; let expected = vec![ ComponentDescriptor { archetype_name: None, archetype_field_name: None, - component_name: "rerun.components.Color".into(), + component_name: "user.CustomPoints3DIndicator".into(), }, ComponentDescriptor { - archetype_name: None, - archetype_field_name: None, - component_name: "user.CustomPoints3DIndicator".into(), + archetype_name: Some("user.CustomPoints3D".into()), + archetype_field_name: Some("colors".into()), + component_name: "rerun.components.Color".into(), }, ComponentDescriptor { - archetype_name: None, - archetype_field_name: None, + archetype_name: Some("user.CustomPoints3D".into()), + archetype_field_name: Some("custom_positions".into()), component_name: "user.CustomPosition3D".into(), }, ]; diff --git a/docs/snippets/all/descriptors/descr_custom_component.rs b/docs/snippets/all/descriptors/descr_custom_component.rs index 14e3f20505bb2..3ad9e97628bd5 100644 --- a/docs/snippets/all/descriptors/descr_custom_component.rs +++ b/docs/snippets/all/descriptors/descr_custom_component.rs @@ -59,18 +59,10 @@ fn check_tags(rec: &rerun::RecordingStream) { .collect::>(); descriptors.sort(); - // TODO(cmc): revert me - // let expected = vec![ - // ComponentDescriptor { - // archetype_name: Some("user.CustomArchetype".into()), - // archetype_field_name: Some("custom_positions".into()), - // component_name: "user.CustomPosition3D".into(), - // }, // - // ]; let expected = vec![ ComponentDescriptor { - archetype_name: None, - archetype_field_name: None, + archetype_name: Some("user.CustomArchetype".into()), + archetype_field_name: Some("custom_positions".into()), component_name: "user.CustomPosition3D".into(), }, // ];