From d800fc0968efd061b4731cada3a76512215f071c Mon Sep 17 00:00:00 2001
From: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Date: Wed, 20 Nov 2024 12:11:19 +0100
Subject: [PATCH] Tweak profiling scopes (#8188)

* [x] ok
---
 crates/store/re_chunk_store/src/writes.rs    |  2 +-
 crates/store/re_entity_db/src/entity_db.rs   | 10 ++++++----
 crates/store/re_entity_db/src/entity_tree.rs |  2 --
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/crates/store/re_chunk_store/src/writes.rs b/crates/store/re_chunk_store/src/writes.rs
index f7f3d17a7d0d..2f168e09545e 100644
--- a/crates/store/re_chunk_store/src/writes.rs
+++ b/crates/store/re_chunk_store/src/writes.rs
@@ -45,7 +45,7 @@ impl ChunkStore {
             return Ok(Vec::new());
         };
 
-        re_tracing::profile_function!(format!("{}", row_id_range.0));
+        re_tracing::profile_function!();
 
         self.insert_id += 1;
 
diff --git a/crates/store/re_entity_db/src/entity_db.rs b/crates/store/re_entity_db/src/entity_db.rs
index e9132f9b2b8a..c2519a2c8ef0 100644
--- a/crates/store/re_entity_db/src/entity_db.rs
+++ b/crates/store/re_entity_db/src/entity_db.rs
@@ -390,8 +390,12 @@ impl EntityDb {
                 .filter(|event| event.kind == ChunkStoreDiffKind::Deletion)
                 .map(|event| event.chunk.entity_path().clone())
                 .collect();
-            self.tree
-                .on_store_deletions(&engine, &entity_paths_with_deletions, &store_events);
+
+            {
+                re_tracing::profile_scope!("on_store_deletions");
+                self.tree
+                    .on_store_deletions(&engine, &entity_paths_with_deletions, &store_events);
+            }
 
             // We inform the stats last, since it measures e2e latency.
             self.stats.on_events(&store_events);
@@ -543,8 +547,6 @@ impl EntityDb {
         mut engine: StorageEngineWriteGuard<'_>,
         store_events: &[ChunkStoreEvent],
     ) {
-        re_tracing::profile_function!();
-
         engine.cache().on_events(store_events);
         times_per_timeline.on_events(store_events);
         time_histogram_per_timeline.on_events(store_events);
diff --git a/crates/store/re_entity_db/src/entity_tree.rs b/crates/store/re_entity_db/src/entity_tree.rs
index 54159429e1ce..89b4ca6cdaf8 100644
--- a/crates/store/re_entity_db/src/entity_tree.rs
+++ b/crates/store/re_entity_db/src/entity_tree.rs
@@ -169,8 +169,6 @@ impl EntityTree {
         entity_paths_with_deletions: &IntSet<EntityPath>,
         events: &[ChunkStoreEvent],
     ) {
-        re_tracing::profile_function!();
-
         // We don't actually use the events for anything, we just want to
         // have a direct dependency on the chunk store which must have
         // produced them by the time this function was called.