Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_file_from_path goes to the right recording but overrides the app_id #8039

Closed
EtaLoop opened this issue Nov 7, 2024 · 6 comments
Closed
Assignees
Labels
🪳 bug Something isn't working 🔩 data model

Comments

@EtaLoop
Copy link
Contributor

EtaLoop commented Nov 7, 2024

Describe the bug
Here, I want to log a supported file (obj) in the "my_app" recording. But with log_file_from_path, this logs to a "/path/to/file/file.obj" recording.
Removing log_file_from_path make it logs correctly to "my_app". So, my guess was that, it renames the recording to the file path?

Is it me doing something wrong here, or no?

I'm on Rerun 0.19.1.
Code :

import rerun as rr

def main():
    rec = rr.init("my_app", spawn=True)
    
    rr.log(
        "triangle",
        rr.Mesh3D(
            vertex_positions=[[0.0, 1.0, 0.0], [1.0, 0.0, 0.0], [0.0, 0.0, 0.0]],
            vertex_normals=[0.0, 0.0, 1.0],
            vertex_colors=[[0, 0, 255], [0, 255, 0], [255, 0, 0]],
            triangle_indices=[2, 1, 0],
        ),
        recording=rec,
    )
    
    rr.log_file_from_path(file_path="/pah/to/file/file.obj", recording=rec)
@EtaLoop EtaLoop added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Nov 7, 2024
@EtaLoop EtaLoop changed the title log_file_from_path not logging to the recording parameter log_file_from_path not logging to the recording given as parameter Nov 7, 2024
@teh-cmc teh-cmc changed the title log_file_from_path not logging to the recording given as parameter log_file_from_path goes to the right recording but overrides the app_id Nov 7, 2024
@teh-cmc teh-cmc added 🔩 data model and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 7, 2024
@teh-cmc teh-cmc self-assigned this Nov 7, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Nov 7, 2024

You are not doing anything wrong, this is one of the many subtle data-loading bugs that were fixed in:

These fixes will ship in 0.20, which is right around the corner (ish).

If you cannot wait for 0.20, you can try using one of our nightly builds instead: https://github.com/rerun-io/rerun/releases/tag/prerelease

@teh-cmc teh-cmc closed this as completed Nov 7, 2024
@EtaLoop
Copy link
Contributor Author

EtaLoop commented Nov 7, 2024

Oh, great ! Thanks

@qianyizhang
Copy link

You are not doing anything wrong, this is one of the many subtle data-loading bugs that were fixed in:

These fixes will ship in 0.20, which is right around the corner (ish).

If you cannot wait for 0.20, you can try using one of our nightly builds instead: https://github.com/rerun-io/rerun/releases/tag/prerelease

I am working with 0.20, still doesn't overwrite the application_id as intended 😣

@qianyizhang
Copy link

another related issue #8167

@teh-cmc
Copy link
Member

teh-cmc commented Nov 19, 2024

You are not doing anything wrong, this is one of the many subtle data-loading bugs that were fixed in:

These fixes will ship in 0.20, which is right around the corner (ish).
If you cannot wait for 0.20, you can try using one of our nightly builds instead: https://github.com/rerun-io/rerun/releases/tag/prerelease

I am working with 0.20, still doesn't overwrite the application_id as intended 😣

I can confirm the script posted in this issue works as expected on 0.20:
image

@teh-cmc
Copy link
Member

teh-cmc commented Nov 19, 2024

another related issue #8167

I'm not following, this is a completely unrelated issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🔩 data model
Projects
None yet
Development

No branches or pull requests

3 participants