Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo warning #8523

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix cargo warning #8523

merged 1 commit into from
Dec 18, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Dec 18, 2024

The warning:

warning: /Users/hhip/src/rerun/crates/utils/re_capabilities/Cargo.toml: `default-features` is ignored for egui, since `default-features` was not specified for `workspace.dependencies.egui`, this could become a hard error in the future

The warning:

```
warning: /Users/hhip/src/rerun/crates/utils/re_capabilities/Cargo.toml: `default-features` is ignored for egui, since `default-features` was not specified for `workspace.dependencies.egui`, this could become a hard error in the future
```
@abey79 abey79 added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
02e4870 https://rerun.io/viewer/pr/8523 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member

Wumpf commented Dec 18, 2024

begs the question whether the top level cargo.toml should do without default features though

@abey79 abey79 merged commit c5ee5d3 into main Dec 18, 2024
37 checks passed
@abey79 abey79 deleted the antoine/fix-cargo-warning branch December 18, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants