Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a drag-and-drop display regression #8228

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 27, 2024

Related

What

This PR fix a display regression introduced in 0.17

0.16

dnd_0.16.mp4

0.17

Note the busy hover highlight and the confusing target-container white frame.

dnd_0.17.mp4

This PR

dnd-fix.mp4

Copy link

github-actions bot commented Nov 27, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
f3c93a2 https://rerun.io/viewer/pr/8228

Note: This comment is updated whenever you push a commit.

@abey79 abey79 added ui concerns graphical user interface 🦟 regression A thing that used to work in an earlier release include in changelog labels Nov 27, 2024
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtle, but now I can't unsee and need this! 😄

crates/viewer/re_ui/src/list_item/list_item.rs Outdated Show resolved Hide resolved
@abey79 abey79 merged commit 18189a4 into main Nov 27, 2024
31 checks passed
@abey79 abey79 deleted the antoine/fix-drag-and-drop-ui-glitch branch November 27, 2024 09:59
teh-cmc pushed a commit that referenced this pull request Nov 28, 2024
### Related

* Closes #8204

### What

This PR fix a display regression introduced in 0.17

#### 0.16


https://github.com/user-attachments/assets/6855b0e0-b5d7-415d-9ea5-e8d51d3111fa

#### 0.17

Note the busy hover highlight and the confusing target-container white
frame.


https://github.com/user-attachments/assets/08085dca-3150-4f01-9d51-c3e981c08651

#### This PR



https://github.com/user-attachments/assets/c100b858-4d97-45f2-85a2-ea17e3f9d0c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag-and-drop in the blueprint tree has glitch
2 participants