Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add filing period selection in gstr-1 beta #2669

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Oct 18, 2024

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 30.64516% with 387 lines in your changes missing coverage. Please review.

Project coverage is 59.84%. Comparing base (29e1bba) to head (4e8365b).
Report is 68 commits behind head on develop.

Files with missing lines Patch % Lines
...st_india/doctype/gst_return_log/generate_gstr_1.py 13.00% 194 Missing ⚠️
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% 74 Missing ⚠️
india_compliance/gst_india/utils/gstin_info.py 10.90% 49 Missing ⚠️
..._compliance/gst_india/api_classes/taxpayer_base.py 28.00% 18 Missing ⚠️
...mpliance/gst_india/utils/gstr_1/gstr_1_json_map.py 43.47% 13 Missing ⚠️
...gst_india/doctype/gst_return_log/gst_return_log.py 62.06% 11 Missing ⚠️
india_compliance/gst_india/utils/e_invoice.py 30.00% 7 Missing ⚠️
...mpliance/gst_india/api_classes/taxpayer_returns.py 50.00% 5 Missing ⚠️
...nce/gst_india/doctype/gstr_1_beta/gstr_1_export.py 0.00% 5 Missing ⚠️
.../gst_india/overrides/subcontracting_transaction.py 83.33% 4 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2669      +/-   ##
===========================================
- Coverage    60.09%   59.84%   -0.25%     
===========================================
  Files          120      121       +1     
  Lines        11549    11973     +424     
===========================================
+ Hits          6940     7165     +225     
- Misses        4609     4808     +199     
Files with missing lines Coverage Δ
...ia_compliance/gst_india/constants/custom_fields.py 100.00% <ø> (ø)
...e/gst_india/doctype/bill_of_entry/bill_of_entry.py 83.88% <100.00%> (-2.81%) ⬇️
...nce/gst_india/doctype/gst_settings/gst_settings.py 77.21% <100.00%> (+0.64%) ⬆️
...gst_india/doctype/gstr_3b_report/gstr_3b_report.py 84.59% <100.00%> (ø)
...iance/gst_india/doctype/gstr_action/gstr_action.py 100.00% <100.00%> (ø)
...ia_compliance/gst_india/overrides/payment_entry.py 66.86% <100.00%> (+0.19%) ⬆️
...compliance/gst_india/overrides/purchase_invoice.py 68.21% <100.00%> (+2.10%) ⬆️
...ia_compliance/gst_india/overrides/sales_invoice.py 81.61% <100.00%> (ø)
...ndia_compliance/gst_india/overrides/transaction.py 89.22% <100.00%> (+0.13%) ⬆️
india_compliance/gst_india/setup/__init__.py 34.16% <ø> (-0.32%) ⬇️
... and 21 more

... and 8 files with indirect coverage changes

Impacted file tree graph

@Sanket322 Sanket322 force-pushed the quartely_in_gstr_1_beta branch from 5ea4171 to 3feb2ea Compare October 22, 2024 06:54
@vorasmit
Copy link
Member

  • Already filed, check frequency of filing and then update if it's or quarterly when creating the log.
  • For already filed, no option to select monthly or quarterly.

@vorasmit vorasmit force-pushed the quartely_in_gstr_1_beta branch from 5fae5f1 to b4625d6 Compare November 4, 2024 06:22
@Sanket322 Sanket322 force-pushed the quartely_in_gstr_1_beta branch from 6ae3d03 to 9eae0d6 Compare November 7, 2024 09:18
@Sanket322 Sanket322 changed the base branch from develop to gstr-1-automation November 9, 2024 10:02
@Sanket322 Sanket322 force-pushed the quartely_in_gstr_1_beta branch from 4e8365b to 35db9ab Compare November 9, 2024 10:15
@vorasmit vorasmit deleted the branch resilient-tech:gstr-1-automation November 11, 2024 08:41
@vorasmit vorasmit closed this Nov 11, 2024
Copy link
Contributor

mergify bot commented Nov 22, 2024

⚠️ The sha of the head commit of this PR conflicts with #2766. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants