Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error message instead of throw during Purchase Invoice name validation (backport #2864) #2866

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

Issue: Support Ticket - 27223

Huly®: IC-2991


This is an automatic backport of pull request #2864 done by Mergify.

… validation (#2864)

* fix: show error message instead of throw

* fix: for purchase invoice use msgprint instead of throw

* test: minor change in test case

* fix: resolve test case for sales invoice

---------

Co-authored-by: Sanket322 <shahsanket322003.com>
(cherry picked from commit a8e5490)
@mergify mergify bot merged commit 1aee6ec into version-15-hotfix Dec 13, 2024
11 checks passed
@mergify mergify bot deleted the mergify/bp/version-15-hotfix/pr-2864 branch December 13, 2024 14:52
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.93%. Comparing base (aa6e7d3) to head (62408b7).
Report is 2 commits behind head on version-15-hotfix.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           version-15-hotfix    #2866      +/-   ##
=====================================================
+ Coverage              59.91%   59.93%   +0.01%     
=====================================================
  Files                    122      122              
  Lines                  12094    12099       +5     
=====================================================
+ Hits                    7246     7251       +5     
  Misses                  4848     4848              
Files with missing lines Coverage Δ
india_compliance/gst_india/utils/__init__.py 76.44% <100.00%> (+0.27%) ⬆️

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant