Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error message instead of throw during Purchase Invoice name validation (backport #2864) #2868

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

… validation (#2864)

* fix: show error message instead of throw

* fix: for purchase invoice use msgprint instead of throw

* test: minor change in test case

* fix: resolve test case for sales invoice

---------

Co-authored-by: Sanket322 <shahsanket322003.com>
(cherry picked from commit a8e5490)

# Conflicts:
#	india_compliance/gst_india/utils/__init__.py
Copy link
Contributor Author

mergify bot commented Dec 13, 2024

Cherry-pick of a8e5490 has failed:

On branch mergify/bp/version-14/pr-2864
Your branch is up to date with 'origin/version-14'.

You are currently cherry-picking commit a8e54900.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   india_compliance/gst_india/overrides/test_purchase_invoice.py
	modified:   india_compliance/gst_india/overrides/test_sales_invoice.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   india_compliance/gst_india/utils/__init__.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.03%. Comparing base (8a170a9) to head (98b6c56).
Report is 2 commits behind head on version-14.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           version-14    #2868      +/-   ##
==============================================
+ Coverage       61.00%   61.03%   +0.02%     
==============================================
  Files             115      115              
  Lines           11154    11161       +7     
==============================================
+ Hits             6805     6812       +7     
  Misses           4349     4349              
Files with missing lines Coverage Δ
india_compliance/gst_india/utils/__init__.py 75.48% <100.00%> (+0.41%) ⬆️

Impacted file tree graph

@vorasmit vorasmit merged commit 5868379 into version-14 Dec 13, 2024
13 checks passed
@vorasmit vorasmit deleted the mergify/bp/version-14/pr-2864 branch December 13, 2024 15:44
india-compliance-bot added a commit that referenced this pull request Dec 13, 2024
## [14.30.11](v14.30.10...v14.30.11) (2024-12-13)

### Bug Fixes

* show error message instead of throw during Purchase Invoice name validation  (backport [#2864](#2864)) ([#2868](#2868)) ([5868379](5868379))
@india-compliance-bot
Copy link
Collaborator

🎉 This PR is included in version 14.30.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants