Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cancel restart/Kill restart feature #2348

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Implement Cancel restart/Kill restart feature #2348

wants to merge 15 commits into from
+1,592 −290

Conversation

slinkydeveloper
Copy link
Contributor

Fix #895. Depends on #2335

The fundamental commit where semantics are implements is this one: 0edc593

Essentially the behavior is the following:

  • Cancel and Kill behaviors are left untouched
  • If the "restart" option is enabled when cancelling/killing, at the end of the invocation the state machine will simply reset the in flight invocation status, removing the pinned deployment id and resetting the journal (except the first entry, that is the input entry)

This commit exposes the feature both in Admin API and in CLI

@slinkydeveloper
Add InvocationStatus::Killed
64b068c
@slinkydeveloper
Add experimental feature InvocationStatus::Killed
6920be4
@slinkydeveloper
Add acknowledgment flag to invoker abort command. This makes sure tha…
025d64e 
…t after a kill, the invoker will send a "terminal" effect to the state machine.
@slinkydeveloper
Plumb the new experimental feature invocation_status_killed.
159b0ac 
Also replace the individual booleans for experimental features with enum set.
@slinkydeveloper
Handle killed invocations during leadership change
9194504
@slinkydeveloper
Reply KILLED when receiving attach/get output and deduplication.
3d25ee9
@slinkydeveloper
Fix cancellation/killing of scheduled invocations.
efd084b
@slinkydeveloper
Add Killed invocation status to CLI
d57419d
@slinkydeveloper
Add invocation status killed test to CI
59628f2
@slinkydeveloper
Add new termination modes to the Admin API
f9aa1b6
@slinkydeveloper
Add field InFlightInvocationMetadata.restate_when_completed, used to …
3052cce 
…store when the invocation should be restarted.

Add new termination flavors to Outbox table. When doing so, I reorganized a bit the data structure of outbox termination.
@slinkydeveloper
Add functionality in journal table to delete a range of the journal, …
de5e0d1 
…rather than the whole journal.
@slinkydeveloper
Implement kill and retry/cancel and retry functionality
0edc593
@slinkydeveloper
Expose the cancel and retry/kill and retry commands in the CLI
a6a0be1
@slinkydeveloper
Add unit tests
53e2e64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman Awaiting requested review from igalshilman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel/Kill and retry invocation from Admin API
1 participant
@slinkydeveloper