Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch the Spend transaction from the Coordinator, apply Spend policies #23

Open
darosior opened this issue Feb 1, 2022 · 2 comments · May be fixed by #31
Open

Fetch the Spend transaction from the Coordinator, apply Spend policies #23

darosior opened this issue Feb 1, 2022 · 2 comments · May be fixed by #31
Assignees
Milestone

Comments

@darosior
Copy link
Member

darosior commented Feb 1, 2022

The annoying part is designing the plugin interface for that.

@darosior darosior added this to the Spend policies milestone Feb 22, 2022
@danielabrozzoni
Copy link
Contributor

Unassigning me as I don't have time to work on it, sorry 😢

@danielabrozzoni danielabrozzoni removed their assignment Feb 28, 2022
@darosior darosior removed this from the Spend policies milestone Mar 1, 2022
@edouardparis
Copy link
Member

edouardparis commented May 30, 2022

I am suggesting to move

Field Type Description
new_attempts array of [Vault resource] Vaults that were just un-vaulted
successful_attempts array of string Outpoints vaults that were spent (defined as an Unvault being spent after the timelock expired).
revaulted_attempts array of string Outpoints of the revaulted vaults

To:

Field Type Description
new_attempts array of [attempt resource] Spending attempts that can be canceled
successful_attempts array of [attempt resource] Outpoints vaults that were spent (defined as an Unvault being spent after the timelock expired).
revaulted_attempts array of [attempt resource] Outpoints of the revaulted vaults

with attempt resource:

Field Type Description
candidate_tx string or null hex encoded Spending transaction (maybe null in that case the attemps must be in revaulted_attempts)
vaults array of Vault resource Vaults concerned by the candidate_txs
blockheight integer or null Block height of the transaction if confirmed else null
  • new_attempts items cannot have no candidate_tx, in that case, the watchtowers already started to revault the vaults and filled instead the revaulted_attempts
  • new_attempts items cannot have two candidate_tx with vaults list overlapping, in that case the watchtowers started to revault the vaults and filled instead the revaulted_attempts

Long term thinking

What if the lists (especially successful attempts) grow to much over time ? Maybe coordinatord stop share the attempts after a very long time calculated by the total of confirmation block ?

@darosior darosior added this to the 11/07 milestone Jul 6, 2022
@darosior darosior linked a pull request Jul 6, 2022 that will close this issue
@edouardparis edouardparis modified the milestone: 11/07 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants