scripts: limit the number of stakeholders and managers to 20 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That looks like a pretty big oversight. And |
darosior
reviewed
Apr 19, 2022
rndhouse
force-pushed
the
limit_stk_mng_count
branch
2 times, most recently
from
9a0e44f
to
fb70b2a
Compare
rndhouse
commented
Apr 20, 2022
rndhouse
force-pushed
the
limit_stk_mng_count
branch
from
fb70b2a
to
6189318
Compare
Let me know once that's done. Current state of the PR looks good to me. |
rndhouse
force-pushed
the
limit_stk_mng_count
branch
from
6189318
to
02d7443
Compare
rndhouse
changed the title
|
I used the this container to run the tests. Non-server black box tests pass for this branch and I get this error for server tests on this branch and for master ( |
darosior
reviewed
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: revault/practical-revault#110
WIP because I haven't ran the revaultd integration tests.
I don't understand why managers are included as stakeholders here (previously hitting stakeholder limit):
revault_tx/src/scripts.rs
Line 1506 in c7e3e29