-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests: add a sample code and run this action with GitHub Actions #33
Comments
Great idea 👍 |
@haya14busa I'll try to do this as I would like to have tests too. In reference to #31, I think we should focus support on the bundler approach as the main way to use this action. I take it you want to see the test workflow from https://github.com/reviewdog/action-template implemented here? Are the jobs there just happy path tests, meaning the action-rubocop would run but report no warnings? If so, I should be able to do that. |
Sorry for the late response. We actually want to have a bad path test. We can create a test dir and put a bad code intentionally , and check (manually) comments will be posted and optimally check the exit code is expected. |
@haya14busa no worries. You're welcome. Happy to help where I can. Do we have another reviewdog action with bad path tests or something similar? I figure we may have something and I can use that as a basis for this. |
You can refer to https://github.com/reviewdog/action-template. |
I think I found some candidates in action-tfsec and action-trivy tests workflows so I'll use that as a basis for this. |
We should add tests to avoid this (#31) kind of failure before merging it similar to https://github.com/reviewdog/action-template and other actions.
@mgrachev Can you work on it?
The text was updated successfully, but these errors were encountered: