Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests: add a sample code and run this action with GitHub Actions #33

Open
haya14busa opened this issue Feb 20, 2021 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@haya14busa
Copy link
Member

We should add tests to avoid this (#31) kind of failure before merging it similar to https://github.com/reviewdog/action-template and other actions.

@mgrachev Can you work on it?

@mgrachev
Copy link
Member

Great idea 👍

@mgrachev mgrachev self-assigned this Feb 20, 2021
@mgrachev mgrachev removed their assignment Mar 26, 2022
@mgrachev mgrachev added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 26, 2022
@javierjulio
Copy link
Contributor

@haya14busa I'll try to do this as I would like to have tests too. In reference to #31, I think we should focus support on the bundler approach as the main way to use this action. I take it you want to see the test workflow from https://github.com/reviewdog/action-template implemented here? Are the jobs there just happy path tests, meaning the action-rubocop would run but report no warnings? If so, I should be able to do that.

@haya14busa
Copy link
Member Author

haya14busa commented Feb 24, 2024

Sorry for the late response.
Thanks, I appreciate your work ♥

We actually want to have a bad path test. We can create a test dir and put a bad code intentionally , and check (manually) comments will be posted and optimally check the exit code is expected.

@javierjulio
Copy link
Contributor

@haya14busa no worries. You're welcome. Happy to help where I can. Do we have another reviewdog action with bad path tests or something similar? I figure we may have something and I can use that as a basis for this.

@haya14busa
Copy link
Member Author

You can refer to https://github.com/reviewdog/action-template.
They aren't exit code check, but I don't remember any good test code.
We should add a test of exit code to the template directory ideally.

@javierjulio
Copy link
Contributor

I think I found some candidates in action-tfsec and action-trivy tests workflows so I'll use that as a basis for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants