Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTOOL_OS_VERSION variable usage #33

Open
RadekCap opened this issue Mar 6, 2023 · 1 comment
Open

OTOOL_OS_VERSION variable usage #33

RadekCap opened this issue Mar 6, 2023 · 1 comment
Assignees
@RadekCap

Comments

@RadekCap
Copy link
Collaborator

RadekCap commented Mar 6, 2023

@RadekCap I have found one other issue (in console of adoptium run higher):
17:50:28 +++ [[ '' -eq 2012 ]]

Variable OTOOL_OS_VERSION is undocumented. Seems like there is some special handling of Windows version 2012. Based on Adoptium test machine name, this version happens to be used for testing. Testing in GH uses more recent version.

Edit:
But it could be some leftover code which is not really necessary anymore.

Originally posted by @zzambers in adoptium/installer#559 (comment)
@RadekCap RadekCap self-assigned this Mar 6, 2023
@RadekCap
Copy link
Collaborator Author

RadekCap commented Mar 6, 2023

This looks like leftover from original source code which distinguished in between machines with and without RAM disk. I'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RadekCap RadekCap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RadekCap