-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk-8-rhel8 vs. redhat-openjdk18-openshift imagestream diffs, user confusion #125
Comments
Hi @gabemontero
I'm not sure why we would have updated that image to the v2 schema and not the others. I can see no reason not to update them all to the v2 schema. I'll take a look at that in a sec.
Quite the opposite. Note that very shortly (today, or in the next couple of days) the *-rhel8 images will be renamed to ubi8/openjdk-XX, although the old names will continue to exist in the RHCC for a transition period. So I am going to update the metadata to reflect only the new names. This also means we can look at putting them in the community metadata, since the UBI images will be public and not requiring an RH account. |
Re v1 versus v2 schema, by eyeball I can't see a difference in the form of those two image descriptions in the image stream metadata here; would it be possible to point me at the v2 schema documentation? |
Here's my planned image streams update, FYI. I've tested this against openshift/library "make import" |
I'm the messenger here as much as anything else @jmtd I think I'm sure that it has to do with the building of the image itself, not parts of the ImageStream yaml. I'm tagging @bparees and @dmage from my team, who alerted me to this. Hopefully they can elaborate. |
On Wed, Apr 29, 2020 at 9:16 AM Gabe Montero ***@***.***> wrote:
Re v1 versus v2 schema, by eyeball I can't see a difference in the form of
those two image descriptions in the image stream metadata here; would it be
possible to point me at the v2 schema documentation?
I'm the messenger here as much as anything else @jmtd
<https://github.com/jmtd>
I think I'm sure that it has to do with the building of the image itself,
not parts of the ImageStream yaml.
yeah this is about docker v2 schema vs v1. Seems like these images were
pushed to the registry w/ a v1 client.
https://docs.docker.com/registry/spec/manifest-v2-2/
https://docs.docker.com/registry/spec/deprecated-schema-v1/
(i'm not sure from the error whether the issue was a "v1" schema, or a
"v2schema1" (as opposed to "v2schema2"). I think v1 is really old, so most
likely the issue is v2schema1 vs v2schema2. Most likely rebuilding the
image and pushing the tag would be sufficient to get a v2schema2 since
that's what osbs should be publishing these days.
Or we can just drop the old tags that are still using old schemas.
I'm tagging @bparees <https://github.com/bparees> and @dmage
… <https://github.com/dmage> from my team, who alerted me to this.
Hopefully they can elaborate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/jboss-container-images/openjdk/issues/125#issuecomment-621190436>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABF6LXRTYPG5XVKC6NSR2XDRPASB5ANCNFSM4MOGVFZQ>
.
--
Ben Parees | OpenShift
|
Hi @bparees OK great. We will be merging a59bde2 imminently which should address this for the RHEL8-based images, at least. There are probably v1-schema tagged images for the RHEL7 branches remaining. I think we remove them in the near future (the older images cause problems for multiarch too, cc @yselkowitz). I'd been quite conservative about doing so up until now but I'm going to follow other image's lead. |
Hey @jmtd
We've had some user/customer confusion recently between those two imagestreams, and in particular some difficulty with openjdk-8-rhel8:1.2 (the latest tag) because it was still using v1 schema
conversely, the redhat-openjdk18-openshift:1.8 tag appears to be v2 schema
there are also questions coming in because of the "rhel8" name and whether they run on rhel7 (openshift still has to support rhel7 worker nodes) ... if that is the case, that would be an issue for openshift and installing that sample imagestream.
is openjdk-8-rhel8 more legacy and no longer being worked on? if so, can it be removed? if not, can we get an update with v2 schema?
when you get a sec let us know what is up ... thanks !!
@bparees FYI
The text was updated successfully, but these errors were encountered: