Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update prometheus JAR MD5 hash in behave test for 0.12.0-8.el8_6 #330

Open
jmtd opened this issue Nov 3, 2022 · 0 comments
Open

update prometheus JAR MD5 hash in behave test for 0.12.0-8.el8_6 #330

jmtd opened this issue Nov 3, 2022 · 0 comments

Comments

@jmtd
Copy link
Member

jmtd commented Nov 3, 2022 

    The md5 hash in the unit test is correct for the artefact we ship in RHEL7 :

-- md5: 8b3af39995b113baf35e53468bad7aae
-  target: jmx_prometheus_javaagent-0.3.2.redhat-00003.jar

I've just confirmed a scratch build with the new pnc stuff pulled in the right artefacts.

But the hash is not correct for UBI8 since we updated prometheus-jmx-exporter-0.12.0-8.el8_6.noarch
(it is now 1a9b7eb478c72028ca91e1bf6e40b48f).

So,

  1. this is further evidence we should just turn off GHA for the rhel7 branch IMHO
  2. we need to update the hash - but in the ubi8 branch, not here

Originally posted by @jmtd in https://github.com/jboss-container-images/openjdk/issues/329#issuecomment-1302163746
jmtd added a commit to jmtd/redhat-openjdk-container-images that referenced this issue Aug 9, 2023
@jmtd
Remove GHA/ubi8 actions from rhel7 branch
76ef91c 
We don't use GHA for the rhel7 images which can't be built without
RHEL entitlements. The UBI8 workflows in the rhel7 branch are out
of date and would fire needlessly if/when we update the rhel7 branch.

Fixes rh-openjdk#330.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd mentioned this issue Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmtd