-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shim 15.6 for EuroLinux 8 #258
Comments
I'm sending you some words. Please post them here when you receive them. |
regnskapsregistrene |
@frozencemetery FYI @jaromaz is currently on vacation during which he wanted to be "offline" && "tech detox" as much as possible. We are trying to reach him, but it might take some time. Sorry for keeping You waiting. |
@frozencemetery @AlexBaranowski My keys are secured offline - I return from vacation on 25.08 and will send the list of words then, since I didn't even take my laptop on this trip. |
privatsamlerens |
Not a problem for me; the only ones who suffer here are you :) In any case, both word sets match; contact verification complete. |
Your README states that you're a "Linux operating system based on Red Hat Enterprise Linux source code". Yet your Dockerfile is building using Oracle Linux. Which is it? Your grub2 sbat has |
The reason for that number 2 in EuroLinux' GRUB2 generation number is that after upstream updated their generation number, we did the same for management simplification. |
All these systems are binary compatible, produce exactly the same artifacts. Of course, there is no problem to use our container, but in the reviews several comments suggested such a procedure: using a container with a different, independent distro, was recommended. |
This is not the correct use of SBAT. |
Everything is explained in SBAT.md, the document SBAT.example.md mislead me a bit. Thank you for pointing out the mistake. We should have given 1 and this number shall not be higher in our case, because we are compatible with Red Hat Enterprise Linux and thus no custom changes will be made here. We fixed the issue and our current review has been updated to the tag eurolinux-shim-x86_64-20220901. |
@frozencemetery @julian-klode Is there anything else we can help with to speed up the process? |
Hi! Is there any ETA for review? |
Please note #307 |
Closing due to shim 15.7 and NX support requirement. |
Confirm the following are included in your repo, checking each box:
What is the link to your tag in a repo cloned from rhboot/shim-review?
https://github.com/EuroLinux/shim-review/tree/eurolinux-shim-x86_64-20220702
What is the SHA256 hash of your final SHIM binary?
9103237187d50053b4dbe37f24851af36c7adfd00de2eab8c1dc83d2706fa43e
The text was updated successfully, but these errors were encountered: