rewrite: switch to nushell #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update rhino-pkg to be nushell with references to the nushell plugin
add dir to put new translations, created format for translations
corrected translation dir path
fixed [y/N] not behaving as intended
re-fixing translation dir path
Added multiple search terms for searching and installs added more robust command checking added aliases
added more aliases
added input filtering to install and remove added the ability to select multiple packages for install and remove
corresponds to previous rhino-pkg commit adding input filtering to install and remove
Solved pacstall error when no packages
Added --multiterm Added sequential search, install and remove Cleaned up functions
Forgot final edit to the help function
Elsie19
requested changes
Dec 11, 2023
|
|
||
| def search-apt [input: string, desc: bool] -> table { | ||
| if (cmd-exist 'apt-cache') { | ||
| let first_table = if $desc == true { |
There was a problem hiding this comment.
Suggested change
| let first_table = if $desc == true { | |
| let first_table = if $desc == true { |
Comment on lines
+39
to
+42
|
|
||
|
|
||
|
|
||
|
|
| def prune-search-table [prune_term: string] -> table { | ||
| let input_table: table = $in | ||
| let downcase_prune_term = ($prune_term |str downcase) | ||
| $input_table | filter { |row| (($row.package | into string | str downcase | str contains $downcase_prune_term) or ($row.description | into string | str downcase | str contains $downcase_prune_term))} |
There was a problem hiding this comment.
Suggested change
| $input_table | filter { |row| (($row.package | into string | str downcase | str contains $downcase_prune_term) or ($row.description | into string | str downcase | str contains $downcase_prune_term))} | |
| $input_table | filter { |row| (($row.package | into string | str downcase | str contains $downcase_prune_term) or ($row.description | into string | str downcase | str contains $downcase_prune_term)) } |
|
|
||
| def search-pacstall [input: string] -> table { | ||
| if (cmd-exist 'pacstall') { | ||
| let pacstall = do { ^pacstall -S $input } | complete |
There was a problem hiding this comment.
Suggested change
| let pacstall = do { ^pacstall -S $input } | complete | |
| let pacstall = do { ^pacstall -S $input } | complete |
| if (cmd-exist 'tput') { | ||
| $terminal_width = ((tput cols) | into int) | ||
| } else if (cmd-exist 'stty') { | ||
| $terminal_width = ((stty size| split column " ").column2.0 | into int) |
There was a problem hiding this comment.
Suggested change
| $terminal_width = ((stty size| split column " ").column2.0 | into int) | |
| $terminal_width = ((stty size | split column " ").column2.0 | into int) |
| def search-cmd-no-args [ ] { | ||
| let command: string = $in | ||
| let error_msg = translation-dir-path | translate invalid.search-arguments {subcommand: $command} | ||
| error make -u {msg: $error_msg} |
There was a problem hiding this comment.
Suggested change
| error make -u {msg: $error_msg} | |
| error make -u { msg: $error_msg } |
| ] -> int { | ||
| if ($rest | is-empty) { | ||
| let error_msg = translation-dir-path | translate invalid.no-subcommand | ||
| error make -u { msg: $error_msg} |
There was a problem hiding this comment.
Suggested change
| error make -u { msg: $error_msg} | |
| error make -u { msg: $error_msg } |
| } | ||
| # "info" | "information" | "data" | "query" | "qry" | "q" => "info", | ||
| if $command == "invalid" { | ||
| let error_msg = translation-dir-path | translate invalid.subcommand {subcommand: $rest.0} |
There was a problem hiding this comment.
Suggested change
| let error_msg = translation-dir-path | translate invalid.subcommand {subcommand: $rest.0} | |
| let error_msg = translation-dir-path | translate invalid.subcommand { subcommand: $rest.0 } |
rhino-pkg
Outdated
Comment on lines
526
to
529
|
|
||
|
|
||
|
|
||
|
|
|
|
||
|
|
||
| } | ||
|
|
Closed
|
Makefile will also need to be edited for the tomls |
oklopfer
commented
Dec 11, 2023
rhino-pkg
Outdated
| individual packages. Has a confirmation prompt. | ||
| #!/usr/bin/env nu | ||
| def translation-dir-path [] -> string { | ||
| "/usr/src/pacstall/rhino-pkg/translation_tomls" |
There was a problem hiding this comment.
this is not a valid dir that will ever exist. it should be in a newly created /usr/local/share/rhino-pkg, not /usr/src/pacstall
oklopfer
commented
Dec 11, 2023
|
@oklopfer any updates on the changes I suggested? |
|
Yeah, you haven’t done any of them yet. It’s your project, Elsie. You maintain it. Not me. |
|
It's your PR but fine. |
|
It’s also all @wren54 ‘s commits. I just made the PR so we could track it. |
moving from vm to bare metal
added the dir "nu-files" which includes the updated and split up rhino-pkg that references different files. Organizes the nu files into the rpk command and then helper scripts that multiple commands reference
should add functionality to detect changes in install dir also add correct makefile
changing makefile because make is fucked up
plugin add nu-tongues
|
This one isn't happening, but look at https://github.com/Elsie19/rpk2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should have a pacstall-programs merge that adds
pacdeps=("nu-tongues-bin")at same time this is merged as well