New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RetryListener use a generic type on the interface not on method. #62

Open

spjoe opened this issue Aug 3, 2016 · 0 comments

spjoe commented Aug 3, 2016

public interface RetryListener {
    <V> void onRetry(Attempt<V> var1);
}

should be:

public interface RetryListener<V> {
    void onRetry(Attempt<V> var1);
}

with this change, withRetryListener would work much more naturally.

Because this is technically a breaking change also a new interface could be introduced and a new method called like withTypedRetryListener

tzachz mentioned this issue

Add type to RetryListener class #77

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment