Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support Conditional Requests to reduce github api usage. #17

Open
KaelBaldwin opened this issue Nov 6, 2018 · 0 comments

Comments

@KaelBaldwin
Copy link

KaelBaldwin commented Nov 6, 2018

go-github supports github API's conditional requests, but it requires you to use your own Transport that is set up for it.

In one of my own projects that uses go-github, I would create an http.Client and set it's Transport to one created using https://github.com/gregjones/httpcache

I would then attach that Client to a context using it's WithValue method.

In order to support the various caching methods, it would be nice if we could pass in a Context object when setting up go-github-selfupdate, that way we could implement Conditional Requests on our end when using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant