-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse paperSize in SceneInfo #39
Comments
@Seb-sti1 yes please for opening a pull request to add this. Based on your version here: Seb-sti1@9505d1d I think the check for And maybe |
Merged
Got it, I'll do that as soon as possible (most likely by the end of the week) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This commit (Seb-sti1@9505d1d) is the addition of paperSize in the SceneInfo class
On the files that had excess bytes, they were
92, 8, 0, 0, 0, 124, 5, 0, 0, 80, 7, 0, 0
which seems to correspond to :92 = 5 (index), 12 (TagType.Length4)
as read and check byDataSteam.read_tag
8, 0, 0, 0
the size 8 bytes here124, 5, 0, 0 = 124 + 5 << 4 = 1404
= first80, 7, 0, 0 = 80 + 7 << 4 = 1872
= secondThe first implementation I tried was with the code below as it seemed to be closer to a simple value but given the existence of what appears to be a size I changed it and used
TaggedBlockReader.read_subblock
. Btw I don't know if it would be better to readsize/4
uint32 instead of the hardcoded two.Originally posted by @Seb-sti1 in #34 (comment)
The text was updated successfully, but these errors were encountered: