Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate with Forest-Tutorials #3

Open
kalzoo opened this issue Feb 6, 2022 · 0 comments · May be fixed by #4
Open

Consolidate with Forest-Tutorials #3

kalzoo opened this issue Feb 6, 2022 · 0 comments · May be fixed by #4

Comments

@kalzoo
Copy link
Contributor

kalzoo commented Feb 6, 2022

Include https://github.com/rigetti/forest-tutorials here and deprecate that repository. Why?:

  • They serve nearly the same purpose, but the latter builds on this repo with a suite of jupyter notebook files that could easily be kept here
  • This extra layer adds more work in propagating updates, fixes, and other changes
  • The dependencies for forest-tutorials are installed ... from a requirements.txt file in this repo.

This was likely set up like this for one of two reasons:

  • Binder uses a Dockerfile as "configuration of last resort" and so this layering prevents Binder from seeing anything but the Dockerfile at the forest-tutorials level
  • Prevent "bloat" of extra notebooks in the forest-notebook docker image ... in reality, this is negligible compared to the overall size of the image. There already is a more-minimal image below this one, rigetti/forest, and having two layers on top of that is unnecessary.

As a confirmation of the rationale here, the Readmes for the two repos are quite similar, mostly overlapping in content. that suggests they serve a single purpose.

@kalzoo kalzoo linked a pull request Feb 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant