Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

側の実装 #73

Merged
merged 6 commits into from
Sep 11, 2023
Merged

側の実装 #73

merged 6 commits into from
Sep 11, 2023

Conversation

1uf3
Copy link
Member

@1uf3 1uf3 commented Jun 9, 2023 •
edited
Loading

close: #71

内部実装はない模様

@1uf3 1uf3 changed the title Feature 71 user service server UserServiceServerの実装 Jun 9, 2023
@1uf3 1uf3 self-assigned this Jun 9, 2023
@1uf3 1uf3 requested a review from CityBear3 June 9, 2023 10:13
@1uf3 1uf3 added the backend label Jun 9, 2023
@1uf3 1uf3 marked this pull request as ready for review June 9, 2023 10:13
CityBear3
CityBear3 reviewed Jun 16, 2023
View reviewed changes
backend/domain/model/user.go Outdated

type UserService interface {
GetUser()
GetUsers()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMO] ここのinterfaceは無くても問題ない気がしますがどうでしょうか？

CityBear3
CityBear3 reviewed Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@CityBear3 CityBear3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user_hanlder.goというファイル名を内部の実装に合わせた名前にした方が良い気がします

@1uf3
Copy link
Member Author

1uf3 commented Jun 23, 2023

たとえばどんな名前にしたほうがいいですか？

@1uf3 1uf3 force-pushed the feature-71-UserServiceServer branch from 7158ac1 to 186665e Compare June 23, 2023 06:53
@1uf3 1uf3 merged commit ff5a926 into dev Sep 11, 2023
@1uf3 1uf3 deleted the feature-71-UserServiceServer branch September 11, 2023 22:21
@1uf3 1uf3 changed the title UserServiceServerの実装 側の実装 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CityBear3 CityBear3 CityBear3 left review comments

Assignees

@1uf3 1uf3

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UserServiceServerの実装
2 participants
@1uf3 @CityBear3