Fix build failures when compiling Cutter with Rizin's dev #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `rz_debug_stop` returns an `int`, so we cannot cast it to
`RxConsBreak`, which is a typedef of a function signature
returning `void`
* `rz_debug_bp_add` siggnatue was recently modified, and thus Cutter
couldn't build with the new signature
* `rz_bin_object_get_imports` was also modified recently to return a
`RzPVector`, thus it also needed to be updated in Cutter
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
5 tasks
|
Rizin PR: rizinorg/rizin#3875. Merge strategy: Rizin -> Cutter -> rz-ghidra |
This comment was marked as resolved.
This comment was marked as resolved.
XVilka
force-pushed
the
update-cutter
branch
from
d232542
to
ebfbc9c
Compare
5 tasks
This comment was marked as outdated.
This comment was marked as outdated.
XVilka
force-pushed
the
update-cutter
branch
from
ebfbc9c
to
1f8430d
Compare
XVilka
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
rz_debug_stopreturns anint, so we cannot cast it toRxConsBreak, which is a typedef of a function signature returningvoidrz_debug_bp_addsiggnatue was recently modified, and thus Cutter couldn't build with the new signaturerz_bin_object_get_importswas also modified recently to return aRzPVector, thus it also needed to be updated in CutterTest plan (required)
Green CI. Git submodule for Rizin has been updated to the latest dev commit: rizinorg/rizin@a21f4bc.
Closing issues
Helps in making the CI green for rizinorg/rz-ghidra#330.
Closes #3245
Closes #3239