Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification what if capacity of excess and shortage is empty #84

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

MaGering
Copy link
Collaborator

@MaGering MaGering commented Nov 16, 2022

With this PR additional info is added concerning the attribute capacity of excess and shortage component:

If it is left empty it is unlimited.

@MaGering MaGering added this to the v0.0.1 milestone Nov 16, 2022
@MaGering MaGering requested a review from jnnr November 16, 2022 10:30
@MaGering MaGering modified the milestones: v0.0.1, v0.0.2 Dec 8, 2022
@MaGering
Copy link
Collaborator Author

MaGering commented Dec 8, 2022

@jnnr could you review this again?

@MaGering
Copy link
Collaborator Author

MaGering commented Aug 31, 2023

This is only true if expandable is True / if investment applies. If False it is set to zero and with the shortage you're going to run into this error with newer solph version.

The info needs to be adapted.

@MaGering MaGering merged commit aac796a into dev Sep 19, 2023
3 checks passed
@MaGering MaGering deleted the feature/add_explanation_cap_shortage_excess branch September 19, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant