Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use illegal json in configs #103

Open
Anarchid opened this issue Jul 4, 2019 · 3 comments
Open

Don't use illegal json in configs #103

Anarchid opened this issue Jul 4, 2019 · 3 comments
Labels
enhancement

Comments

@Anarchid
Copy link

Anarchid commented Jul 4, 2019 •
edited
Loading

The feature that allows Circuit to have comments in its JSON configs seems to be fragile: ZeroK-RTS/Zero-K-Infrastructure#2596

Converting configs to a format that supports comments directly - e.g. hjson, - rather than in violation of its standard, should address that.
@rlcevg
Copy link
Owner

rlcevg commented Jul 7, 2019 •
edited
Loading

Also Zero-K-Infrastructure#2596 issue is not relevant: someone forgot to put comma in array declaration, as json parser informed inside infolog.

GoogleFrog added a commit to ZeroK-RTS/Chobby that referenced this issue Jul 8, 2019
@GoogleFrog
Added comma for circuit AI. Fixes #699. Fixes ZeroK-RTS/Zero-K-Infras…
bd24674 
…tructure#2596. See rlcevg/CircuitAI#103.
@rlcevg
Copy link
Owner

rlcevg commented Apr 14, 2020

Added AngelScript. An option is to replace json config by AS script, supports comments.

@rlcevg
Copy link
Owner

rlcevg commented Sep 27, 2020

Another reason to migrate from json is duplicate key entries - no error raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlcevg @Anarchid