Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain based routing: Should extractFromDomain function get it from the X-Forwarded-Host header? #132

Open
fprl opened this issue Aug 29, 2024 · 1 comment
Labels
question Further information is requested

Comments

@fprl
Copy link

fprl commented Aug 29, 2024

Hi Roberto, again, thank you for this library.

I was wondering if the extractFromDomain function should get the hostname from the X-Forwarded-Host header instead of the url and fallback to the 'host' header or url as a last resort.

Why? The presence of a reverse proxy or load balancer would make this feature not work with the current approach.

Thank you!

@robisim74
Copy link
Owner

Thanks @fprl If you have the opportunity to test the modified code in production, and you want to share it or make a PR, you are welcome.

@robisim74 robisim74 added the question Further information is requested label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants