Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services should be allowed to start with a warning if icon not provided or does not exist #220

Open
piyushk opened this issue Apr 14, 2014 · 1 comment

Comments

@piyushk
Copy link
Contributor

piyushk commented Apr 14, 2014

Mostly an enhancement. I don't want to copy placeholder icons around. I got the following error:

could not find service profile[concert_service_gazebo/segbot]

generated from https://github.com/robotics-in-concert/rocon_concert/blob/hydro-devel/concert_service_manager/src/concert_service_manager/service_profile.py#L73
because my icon did not exist - https://github.com/robotics-in-concert/rocon_concert/blob/hydro-devel/concert_service_manager/src/concert_service_manager/service_profile.py#L141

@stonier
Copy link
Member

stonier commented Apr 14, 2014

Could definitely at least use a better feedback message.

I think I prefer stopping the service though. It helps the user get their service profile factually correct, i.e. in this case deleting the icon parameter is sufficient for catering to those who haven't gotten around to configuring an icon and also makes sure the service profile doesn't present information which actually isn't true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants