Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanonicalLink updates #329

Closed
diegoferigo opened this issue Apr 9, 2021 · 2 comments
Closed

CanonicalLink updates #329

diegoferigo opened this issue Apr 9, 2021 · 2 comments

Comments

@diegoferigo
Copy link
Collaborator

There is some upstream activity in gazebosim/gz-sim#736 that touches the CanonicalLink component. Refer to gazebosim/gz-sim#736 (comment) and other comments.

Changes will not break the functionality within Edifice (the target branch of the PR) and nothing will stop working from our side, though I open this issue as reminder to check what's the outcome of the PR and adapt, if needed, align our logic. Currently, our devel branch supports Edifice.

Currently we use the CanonicalLink component in the following methods:

@adlarkin
Copy link

Just so you're aware, we changed how things were implemented in gazebosim/gz-sim#736 so that the CanonicalLink component remains unchanged (gazebosim/gz-sim#736 (comment)). So, hopefully, you don't need to change anything 🙂

@diegoferigo
Copy link
Collaborator Author

Hi @adlarkin, thanks for chiming in! Awesome, it seems a much more neat and future proof solution moving the logic into the Physics system. Great work! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants