Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imrpove grapheme.split testing #7

Open
Anton-4 opened this issue May 4, 2024 · 1 comment
Open

Imrpove grapheme.split testing #7

Anton-4 opened this issue May 4, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Anton-4
Copy link
Collaborator

Anton-4 commented May 4, 2024

Quoted from Luke:

coverage of the unicode data file test points is pretty average, like it might only have a test that covers an emoji at the start of a string, but not the middle or end or before a CLRF or after a Hangul sequence... etc.
So I'm reasonably confident there are a couple of edge cases we haven't caught, and could end up crashing someone's code. It would be nice to get that to a point where we are reasonably confident that is not going to happen.

@lukewilliamboswell
Copy link
Collaborator

This is a fun project for anyone who has the time and interest. Brendan's https://github.com/bhansconnect/roc-fuzz platform would be a great way to test this.

I have had plans to do this, but haven't had an opportunity yet.

@lukewilliamboswell lukewilliamboswell added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants