Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlaneFitting for underspecified planes does not necessarily return an xy-plane #4

Open
chhtz opened this issue Nov 12, 2015 · 0 comments

Comments

@chhtz
Copy link
Member

chhtz commented Nov 12, 2015

Example:

    PlaneFitting<float> pf1, pf2;
    pf1.update(Eigen::Vector3f(0,0,-1));
    std::cout << pf1.getCoeffs().transpose() << std::endl; // [0 0 -1], as expected
    pf2.update(Eigen::Vector3f(2,3,-1));
    std::cout << pf2.getCoeffs().transpose() << std::endl; // [0, -1/3, 0] 
         // which is a solution of smaller norm, but not as expected

As long as x and y coordinates have magnitude<1.0 the current implementation works. I'm not sure if this is worth addressing (but probably it should be pointed out in the documentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant