-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Term? #614
Comments
Coincidentally, what is that number? |
yup, building just the latest minor version (i.e. 4.1.3, but not other 4.1.x) seems reasonable? |
For now, would the following looks good?
The number of minor versions will eventually need to be limited, but for now I think it makes sense to support all versions since R 4.0. |
Resolve #614 Reduce the number of images to be built according to the following new standard: - All patch versions associated with the last 2 minor versions (release and oldrel) - All minor versions R >= 4.0
Related to #776, I think it is time to revisit this. In particular, I am wondering about the dealing with images that contain Python packages.
I would like to move the cuda based images and the binder to extra and stop all builds except the latest two. In addition, I would like to remove Dockerfiles prior to 4.2.0, as it would be difficult to migrate all past Dockerfiles to the new architecture. @cboettig Thoughts? |
What about keeping 'max(z) in x.y.z' to keep, say, 4.2.3 and 4.3.3? |
I think it makes sense to support the two latest minor versions, consistent with the checks on CRAN, and I believe Docker Official Images also continues to build the versions that are normally supported. |
Thanks @eitsupi , agree we need to revisit this. Just wrapping my head around the various levels at which we define 'support'. I agree that it makes sense to transition to less-aggressive rebuild. Also agree it makes sense to split out the cuda stack separately. While I think there probably is some value to being able to preserve older cuda versions in theory, we aren't attempting to track cuda releases anyway, so I'm fine with it building only the last two. The binder images have been around a lot longer, have a considerable user base and build more directly on the same stack than the cuda images do. I would prefer we do not separate the binder images out from the r-ver stack, at least not without more community input. I don't quite follow the case for 'deleting' dockerfiles. I'm looking forward to the migration to the new architecture, and I think we don't need to port pre 4.2 images over there if that simplifies things, similar to what we did at the time of the 20.04 LTS release? |
Thanks, to be clear, I do not want to split the repository, I want to split the build GHA jobs.
In other words, I think it would be better to use the following Dockerfile and requrements.txt and have it updated by dependabot. FROM rocker/geospatial:4.3.3@sha256:568082b1a92dd9471a522fdf8038c6dd9968dac28599f7457c19ff9da7d89cd0
COPY requirements.txt /tmp/requirements.txt
... |
ah, thanks for clarifying, yes I like this proposal! |
Closed by #782 |
With the release of R 4.2.3, we finally have more versions built than the number of GitHub Actions parallel execution workflows.
I don't think it is a sustainable approach to keep increasing the number of builds, so I am wondering if it is possible to stop building images that are considered unimportant (e.g. not the final version of X.Y like R 4.0.1).
The text was updated successfully, but these errors were encountered: