-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"CI" tag for system dependencies only #312
Draft
noamross
wants to merge
2
commits into
master
Choose a base branch
from
renv-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
#!/bin/bash | ||
set -e | ||
|
||
## build ARGs | ||
NCPUS=${NCPUS:--1} | ||
|
||
# always set this for scripts but don't declare as ENV.. | ||
export DEBIAN_FRONTEND=noninteractive | ||
export PATH=$PATH:/usr/local/texlive/bin/x86_64-linux/ | ||
|
||
apt-get update | ||
|
||
#----- SysDeps for Tidyverse----- | ||
apt-get install -y --no-install-recommends \ | ||
file \ | ||
git \ | ||
libapparmor1 \ | ||
libgc1c2 \ | ||
libclang-dev \ | ||
libcurl4-openssl-dev \ | ||
libedit2 \ | ||
libobjc4 \ | ||
libssl-dev \ | ||
libpq5 \ | ||
lsb-release \ | ||
psmisc \ | ||
procps \ | ||
python-setuptools \ | ||
pwgen \ | ||
sudo \ | ||
wget | ||
|
||
#----- SysDeps for Verse----- | ||
apt-get install -y --no-install-recommends \ | ||
cmake \ | ||
default-jdk \ | ||
fonts-roboto \ | ||
ghostscript \ | ||
hugo \ | ||
less \ | ||
libbz2-dev \ | ||
libglpk-dev \ | ||
libgmp3-dev \ | ||
libfribidi-dev \ | ||
libharfbuzz-dev \ | ||
libhunspell-dev \ | ||
libicu-dev \ | ||
liblzma-dev \ | ||
libmagick++-dev \ | ||
libopenmpi-dev \ | ||
libpcre2-dev \ | ||
libv8-dev \ | ||
libxml2-dev\ | ||
libxslt1-dev \ | ||
libzmq3-dev \ | ||
qpdf \ | ||
texinfo \ | ||
software-properties-common \ | ||
vim | ||
|
||
# librdf0-dev depends on libcurl4-gnutils-dev instead of libcurl4-openssl-dev... | ||
# So: we can build the redland package bindings and then swap back to libcurl-openssl-dev... (ick) | ||
# explicitly install runtime library sub-deps of librdf0-dev so they are not auto-removed. | ||
apt-get install -y librdf0-dev | ||
install2.r --error --skipinstalled -n $NCPUS redland | ||
apt-get install -y \ | ||
libcurl4-openssl-dev \ | ||
libxslt-dev \ | ||
librdf0 \ | ||
redland-utils \ | ||
rasqal-utils \ | ||
raptor2-utils \ | ||
&& apt-get remove -y systemd \ | ||
&& apt-get -y autoremove | ||
|
||
apt-get install -y libgit2-dev libcurl4-openssl-dev | ||
|
||
## Add LaTeX, rticles and bookdown support | ||
wget "https://travis-bin.yihui.name/texlive-local.deb" \ | ||
&& dpkg -i texlive-local.deb \ | ||
&& rm texlive-local.deb | ||
|
||
## Install texlive and pandoc | ||
/rocker_scripts/install_texlive.sh | ||
/rocker_scripts/install_pandoc.sh | ||
|
||
#----- SysDeps for Geospatial----- | ||
|
||
apt-get install -y --no-install-recommends \ | ||
gdal-bin \ | ||
lbzip2 \ | ||
libfftw3-dev \ | ||
libgdal-dev \ | ||
libgeos-dev \ | ||
libgsl0-dev \ | ||
libgl1-mesa-dev \ | ||
libglu1-mesa-dev \ | ||
libhdf4-alt-dev \ | ||
libhdf5-dev \ | ||
libjq-dev \ | ||
libpq-dev \ | ||
libproj-dev \ | ||
libprotobuf-dev \ | ||
libnetcdf-dev \ | ||
libsqlite3-dev \ | ||
libudunits2-dev \ | ||
lsb-release \ | ||
netcdf-bin \ | ||
postgis \ | ||
protobuf-compiler \ | ||
sqlite3 \ | ||
tk-dev \ | ||
unixodbc-dev | ||
|
||
|
||
#----- Cleanup ----- | ||
rm -rf /var/lib/apt/lists/* | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cboettig Not sure what is needed in this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this is a bit of a mess. debian/ubuntu ship a few different versions of libcurl (specifically, gnutils vs openssl), which conflict. (Some packages can bind either one, but don't necessarily play nicely with both -- e.g. I believe
curl
R package doesn't fail but does some unexpected things with the non-openssl version iirc?)The
redland
R package needslibrdf0-dev
which depends on gnutils, meaning that line 64 will uninstalls the openssl version and potentially breaks things. So if we're going to installlibrdf0-dev
, I think it is necessary to reinstalllibcurl4-openssl-dev
after we finish buildingredland
from source (maybe not necessary now that we can get binaries??)Anyway, long story short, I've always been very confused about the libcurl conflict. @eddelbuettel or @jeroen probably have a much better handle on this; maybe one of them could advise what's the best way to support both redland and curl R packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, do not have a fix. There are alternative implementations, which in turn are use by different packages, so you could indeed end up with 'graph' with conflicts. Best solution might be to locally rebuild packages using, say, gnutls to use openssl. Not something I tried though.