Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarize rootless instructions #101

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

zeehio
Copy link
Contributor

@zeehio zeehio commented Oct 8, 2023

This PR has a balance of 117 additions and 209 deletions.

Six months ago I wrote an article about using rocker in rootless containers.

Some settings were complicated due to limitations in the --gidmap syntax exposed by Podman.

As discussed there, I ended up contributing syntax enhancements to Podman.

This PR simplifies the explanations of the rootless page in the website, using the lessons learned while working on Podman. It also focuses on the how it works instead of the why it works, now that the syntax improvements make options more natural.

It preserves instructions for earlier podman versions, although upgrading is encouraged.

Include instructions for podman >=4.7
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

A few comments.

use/rootless.md Outdated Show resolved Hide resolved
use/rootless.md Outdated Show resolved Hide resolved
@zeehio
Copy link
Contributor Author

zeehio commented Oct 8, 2023

Thanks for the quick feedback!

@zeehio
Copy link
Contributor Author

zeehio commented Oct 8, 2023

I'll fix the indentation issues later if you want

@eitsupi
Copy link
Member

eitsupi commented Oct 8, 2023

I'll fix the indentation issues later if you want

It would be helpful!

Also, I would appreciate it if you could clearly indicate "Terminal" in every sh code block like this.

website/use/gui.md

Lines 19 to 21 in 86a5e3a

```{.sh filename="Terminal"}
docker run --rm -ti -p 8000:8000 ghcr.io/rocker-org/devcontainer/r-ver:4 R
```

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eitsupi eitsupi requested a review from cboettig October 8, 2023 14:04
@cboettig
Copy link
Member

cboettig commented Oct 9, 2023

This looks great to me. My only concern is that it might be better to title this as rootless podman? I understand individuals run in rootless mode in a few different ways (singularity, podman, I believe jupyter-server-proxy on 2i2c and binder setups is rootless, and so forth). It might avoid confusion if this is called rootless-podman.md and the title is something like "running without root privileges using podman" ?

@eitsupi
Copy link
Member

eitsupi commented Oct 9, 2023

My only concern is that it might be better to title this as rootless podman?

Fair point.
There is already a page about singularity.
https://github.com/rocker-org/website/blob/86a5e3a1fbce88741fa69e7f0efbe644425fe67e/use/singularity.md

@zeehio
Copy link
Contributor Author

zeehio commented Oct 9, 2023

Good point! I changed the title :-)

use/rootless-podman.md Outdated Show resolved Hide resolved
@eitsupi
Copy link
Member

eitsupi commented Oct 9, 2023

Thanks, merging.

@eitsupi eitsupi merged commit eb4b971 into rocker-org:master Oct 9, 2023
2 checks passed
eitsupi added a commit that referenced this pull request Oct 9, 2023
A follow up for #101 (Sorry, I forgot about this)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants