Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/conversion.go treats in floats when decimal would be lossless #11

Open
jshufro opened this issue Jun 27, 2024 · 0 comments
Open

eth/conversion.go treats in floats when decimal would be lossless #11

jshufro opened this issue Jun 27, 2024 · 0 comments

Comments

@jshufro
Copy link
Contributor

jshufro commented Jun 27, 2024

Various utility functions in this file convert between big.Int and float64... There's prefectly usable tooling in go-ethereum that defines a Decimal256 type, which would allow us to parse eth values losslessly (eg 123456789123456.123456789012345678) without using float64, which creates precision loss https://go.dev/play/p/xh06-b8xldG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant