Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFL scoring information to Boxscore #759

Open
1jonahg1 opened this issue Nov 18, 2022 · 1 comment
Open

Add NFL scoring information to Boxscore #759

1jonahg1 opened this issue Nov 18, 2022 · 1 comment

Comments

@1jonahg1
Copy link

1jonahg1 commented Nov 18, 2022

I'm in the process of adding an option to NFL Boxscore to get all the scoring possession details from the game, as shown on the Sports Reference website, and would like to get input on the feature before I create a pull request. Following is the general documentation for the feature:

Returns a "list" containing a list for each quarter's scores. Each score is represented by a "dictionary" that holds the following keys:

  • 'time' - Time on the clock until the end of the quarter.
  • 'team' - The scoring team's name.
  • 'details' - A summary of the scoring play, including players involved.
  • current_score' - A dictionary with the current score after the scoring play. It's keys are: 'home', 'away'.

For example:

        [
            [<1st-quarter-scores>], [<2nd-quarter-scores>], 
            [<3rd-quarter-scores>], [<4th-quarter-scores>],
            [<overtime-scores>] 
        ]

Example for <1st-quarter-scores>:

            [
                {
                    'time': '7:51',
                    'team': 'Giants', 
                    'details': 'Lawrence Cager 9 yard pass from Daniel Jones Graham Gano kick)',
                    'current_score': {'away': '0', 'home': '7'}
                }
            ]
@bveber
Copy link

bveber commented Nov 21, 2022

This is a cool idea. One consideration you might want to make, is dumping the dictionary into a stringified JSON and including it as a field in the output dataframe.

That said, this repo appears to be abandoned by the admin. I have a fork that I'm using for my own purposes and I'm in the process of updating the codebase to accomodate several changes that have been made to the website that have broken some features. If you implement this change you might be better off forking it yourself. But I'm interested in seeing your changes when you make them and I'd be happy to collaborate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants