Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add a Throughput in the Summary #2

Open
kataras opened this issue Jan 14, 2020 · 2 comments
Open

[FEATURE REQUEST] Add a Throughput in the Summary #2

kataras opened this issue Jan 14, 2020 · 2 comments
Labels
feature-request New feature or request

Comments

@kataras
Copy link
Contributor

kataras commented Jan 14, 2020

Hello @rogerwelin,

First of all I have to say that this is a great project with clean source code, I was able to understand the code flow very quickly, good job!

I just want to add a Throughput label in the Summary section of the results output. I think it's quite useful for us, who develop web frameworks, to see that number right away. Also, you can move the CLI part package main on a "./cmd/cassowary" directory so we can use the github.com/rogewelin/cassowary package as a library too to take the results directly. I know that you have json output option too but it will require from us to download executable based on the host OS, then exec.Cmd, then read the json file and unmarshal it which it is quite slow operation and requires many steps that can fail.

Thanks again,
Gerasimos Maropoulos. Author of Iris web framework

@rogerwelin
Copy link
Owner

@kataras Thanks for your encouraging words, definitely motivates me to improve the project.

I will add throughput as a to-do.

You're definitely right about moving out the CLI part so the rest can be used as a library. I did not envision the project to be used as more than a cli tool but I definitely see the use case here.

About the json output as a file; I think adding a new method that just returns the struct may be the way to go

@kataras
Copy link
Contributor Author

kataras commented Jan 15, 2020

You're welcome @rogerwelin, it's my honor!

I've just pushed the first PR in this repository as well! I could help you structuring your project (including some use cases I find you duplicate code) if you let me to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants