You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all I have to say that this is a great project with clean source code, I was able to understand the code flow very quickly, good job!
I just want to add a Throughput label in the Summary section of the results output. I think it's quite useful for us, who develop web frameworks, to see that number right away. Also, you can move the CLI part package main on a "./cmd/cassowary" directory so we can use the github.com/rogewelin/cassowary package as a library too to take the results directly. I know that you have json output option too but it will require from us to download executable based on the host OS, then exec.Cmd, then read the json file and unmarshal it which it is quite slow operation and requires many steps that can fail.
@kataras Thanks for your encouraging words, definitely motivates me to improve the project.
I will add throughput as a to-do.
You're definitely right about moving out the CLI part so the rest can be used as a library. I did not envision the project to be used as more than a cli tool but I definitely see the use case here.
About the json output as a file; I think adding a new method that just returns the struct may be the way to go
I've just pushed the first PR in this repository as well! I could help you structuring your project (including some use cases I find you duplicate code) if you let me to.
Hello @rogerwelin,
First of all I have to say that this is a great project with clean source code, I was able to understand the code flow very quickly, good job!
I just want to add a
Throughput
label in theSummary
section of the results output. I think it's quite useful for us, who develop web frameworks, to see that number right away. Also, you can move the CLI partpackage main
on a"./cmd/cassowary"
directory so we can use thegithub.com/rogewelin/cassowary
package as a library too to take the results directly. I know that you have json output option too but it will require from us to download executable based on the host OS, thenexec.Cmd
, thenread
the json file and unmarshal it which it is quite slow operation and requires many steps that can fail.Thanks again,
Gerasimos Maropoulos. Author of Iris web framework
The text was updated successfully, but these errors were encountered: