Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollbar.prototype.wait() for browser envrironment #1138

Open
mstssk opened this issue Apr 5, 2024 · 0 comments
Open

Rollbar.prototype.wait() for browser envrironment #1138

mstssk opened this issue Apr 5, 2024 · 0 comments

Comments

@mstssk
Copy link

mstssk commented Apr 5, 2024

Rollbar.prototype.wait() is missing in browser implementation.

It would seem that the same implementation should be done on the server side.

Rollbar.prototype.wait = function (callback) {
this.client.wait(callback);
};
Rollbar.wait = function (callback) {
if (_instance) {
return _instance.wait(callback);
} else {
var maybeCallback = _getFirstFunction(arguments);
handleUninitialized(maybeCallback);
}
};

Unless there is some special reason, I will create a PR.

@linear linear bot added the Rollbar.js label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant