Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit/functional tests #10

Open
ishakuta opened this issue Jun 10, 2015 · 3 comments
Open

Add unit/functional tests #10

ishakuta opened this issue Jun 10, 2015 · 3 comments

Comments

@ishakuta
Copy link
Contributor

most of the issues we found so far was due to zero unit tests coverage,
can be also some sort of functional tests

@Zifius
Copy link
Contributor

Zifius commented Sep 9, 2015

Hi @ishakuta, which approach/tools do you suggest for testing?

@ishakuta
Copy link
Contributor Author

ishakuta commented Sep 9, 2015

Hi @Zifius, phpunit with client mock to check different use cases

@romanpitak
Copy link
Owner

I've started adding some tests into the devel/tests branch. For now, I'm focusing on testing the data types against the wadl specification. My idea is to have an abstract test (e.g. EnumTest) and then inherit specific tests (e.g. ApiAddressBookVisibilityTest, ApiSurveyStateTest) which would only serve the purpose of adding the correct class name and coverage information. The inherited classes can IMHO be generated and then (if needed) specific tests can be added to them. I've added this (into the phpunit.xml) as a separate testsuite (separated from future Resources testing) as it doesn't require a client.

I believe that writing a mock client would be too much work, although generating one from the wadl shouldn't be a problem.

CC @Zifius, @ishakuta: I'd very much appreciate your comments (critique, hints, recommendations...) on the new branch as I'm not skilled in testing.

PS Thank you for caring and participating :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants