-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7 Compatibility issue #22
Comments
Any chance that this can be patched? Using the library and going to cause issues on server running PHP 7 which is using Envoyer for deployments and will overwrite these changes every time. |
Same problem here... |
I see this issue first came up in 2016 it is now 2019 and the composer package still does not have this fixed. Any update? |
The list of reserved words has been updated in PHP 7 to include ‘null’, which is used as a class name for the null DataType.
I got around it by just renaming Null class to NullDataType and updating the references. As far as I know the only reference is on line 60 of
DataTypes/JsonObject.php
.I haven’t gone so far as to submit a PR as I'm wondering if the issue needs more thought, for example ‘mixed’ may well be reserved in future versions of PHP (see here). Perhaps all the core data types could be name spaced in some way?
Anyway - this library is awesome and has saved me an awful lot of time, so thank you!
The text was updated successfully, but these errors were encountered: