Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: correction in React Router #5

Open
ronaldosc opened this issue Apr 18, 2023 · 0 comments
Open

Frontend: correction in React Router #5

ronaldosc opened this issue Apr 18, 2023 · 0 comments

Comments

@ronaldosc
Copy link
Owner

Alpha-TaqTech#51

PR title: "fix/feat: fixed react-router-dom, implement favicons and relatives, and some other minimal corrections"

propositions branch: react-router

PR message content:

- corrigi para usar apenas o `react-router-dom`
- implementei os `favicons` ajustáveis, então adicionou várias linhas no HTML e vários ícones organizados em uma só pasta dentro de *assets*
- na pasta `pages` o arquivo index.ts estava com os caminhos errados
- a página `Error404` reduzi o tamanho do bloco onde fica a mensagem e que fica mais ou menos centralizado, mas se alguém puder, aplicar a centralização do texto lá
- alguns locais é melhor importar com o nome `React` por ser um *namespace* ([site que explica sobre o assunto](https://br.atsit.in/archives/108112)).
  Caso eu esteja enganado para essa lib sobre o assunto, me avise por favor!

conflicts:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant