[webcanvas] Improving usability with stressGraphics tests #17072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is now handled by TGraph2D and does not require histogram filling Also P and P0 uses real TGraph2D drawing
Check X+ or Y+ to create histogram
Let create TGraphPolargram when necessary Provide access to polargram object Avoid TFrame creation, create title
If gStyle->GetOptFit() returns 0, stats box for TGraph with TF1 will not be created
Process several drawings sequentially to avoid concurency and high memory consumption. If done sequentially - there is no ambiguity which gStyle instance has to be used. Catch JSROOT exceptions (if any) - process at least images which can be created and mark missing images as failures
If failure happens during image production, report it and try to create other images
If in web mode root or xml file is created do not print warning
When required, instantiate TRandom3 instance directly. Try to avoid interference with other tests relying on gRandom
Use better C++ syntax in the code Replace "samecolorz" by "samecolz" option in waves() test Set fixed time offset in tgaxis3() to get reproducible axis labels
Let read several reference files generated by running `stressGraphics -r` And then find min/max for each test. Define error as 1.5 of maximal deviation from mean value To generate new reference file, call ./stressGraphics --build *.txt
1. Implement cont5 draw option for `TGraph2D` using Delaunay algorithm 1. Adjust histogram title drawing with native implementation 1. Improve float to string convertion when 'g' is specified 1. Support "same" option for first histogram, draw direcly on pad 1. Support different angle coordiantes in `TGraphPolargram` 1. Fix - handle `TPave` NDC position also when fInit is not set 1. Fix - correctly position title according to gStyle->GetTitleAlign() 1. Fix - correctly handle tooltip events for `TGraphPolar` 1. Fix - align in #splitline Many other small changes to make stressGraphics output very-very similar to original graphics
Generated on base of tests on: - Linux chrome/firefox - MacOS chrome/firefox - Win64 chrome/firefox/edge Produced with command: ``` ./stressGraphics --web --build st*.txt > stressGraphics_web.ref ```
couet
approved these changes
Nov 26, 2024
Test Results 17 files 17 suites 3d 22h 39m 29s ⏱️ For more details on these failures, see this check. Results for commit 782871d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canv_batch.htmsequentially. Solves memory usage problem when running browsers in headless mode - fromstressGraphicsfor instance. Handle exceptions to avoid hanging of headless browser. Report failures up to user output.gRandomusage inwebdisplayclasses. Instead - just create and use TRandom3 instance when necessary. Because of it stressGraphics in web mode was producing results which differ too much from each otherstressGraphicsto analyze test results and generate reference table. ProvidestressGraphics_web.reffile after testing on all platforms / all supported browsers.TWebCanvasto properly handle draw options for TGraph / TGraph2DTGraph2Din JSROOTgStyle->GetTitleAlign()valuewaves()tutorialgqualifier, makes stat box output similar to ROOT oneTGraphPolar, support this class inTWebCanvas#splitlinedirective of TLatexportrait/landscapeproblem in pdf generation withsvg2pdf.js