Adapt to change in error case behavior. #1226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of writing with the 'wrong' TStreamerInfo, the hadd of two file with conflicting StreamerInfo with the same version number write with the 'right' StreamerInfo ... but that StreamerInfo has missing fields with are now omitted in the writing. The use case has 2 StreamerInfos: (a) v10 of ParticleImplVec which inherits from v11 of Particle which contains 3 floats (b) v10 (also) of ParticleImplVec which inherits from v12 of Particle which contains a float and moves the 3 pre-existing float into a base class (so they are 'missing' when using v11 of Particle). The previous behavior of the hadd invocation was streaming v10-a of ParticleImplVec but ended up continuing the streaming with v12 of Particle Now the hadd invocation is still streaming v10-a of ParticleImplVec but is continuing with streaming with its corresponding v11 of Particle which has missing data member (those moved in the base) so during Streaming we could either write arbitrary values (0) or (the choice that is made) we just skip them leading to a more clear error at read time: ``` Error in <TBufferFile::CheckByteCount>: object of class vector<ParticleImplVec> read too many bytes: 56 instead of 8 ``` Note that the `56` is actual another consequence of the 'broken' setup in which hadd had to run (duplicate version number) and the reading is incorrectly trying to read with version 12 of Particle. Reminder: the point of these tests is to ensure that there is sufficient error output is case of this type of mixed up setup.
You can now create a symlink or subdirectory called ArchivedDataFiles. You can also set the environment variable ROOT_NEWSTL_DATAFILE_DIR
dpiparo
approved these changes
Nov 26, 2024
pcanal
force-pushed
the
master-non-defaults-enums
branch
from
3fbd6a0
to
556a7c8
Compare
pcanal
force-pushed
the
master-non-defaults-enums
branch
from
556a7c8
to
13dba6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is chained on #1224 and is the companion PR to root-project/root#17009