Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added composer.json support #10

Closed
wants to merge 5 commits into from
Closed

Added composer.json support #10

wants to merge 5 commits into from

Conversation

vinkla
Copy link
Collaborator

@vinkla vinkla commented Jun 9, 2019

This pull request adds Composer support to the autoloader. Couple of questions before this pull request can be merged:

  1. Should it be named roots/bedrock-autoloader or roots/autoloader?
  2. Should it live on as a mu-plugin or as a "normal" Composer package (discussed in Decouple logic from actual autoloader class filesystem location #5)?
  3. Whom should we specify as authors?

Closes #1

vinkla and others added 3 commits June 9, 2019 19:28
I'm gonna be managing the composer repo as well
@austinpray
Copy link
Collaborator

  • Should it be named roots/bedrock-autoloader or roots/autoloader?

I suppose if we are doing things properly this is not necessarily coupled with bedrock specifically? It should really be like "plugin-autoloader" or something. cc @roots/everyone

Normal composer package as per @aaemnnosttv's recommendation. This is a library that one can use in their own file dropped in the mu-plugins directory.

  • Whom should we specify as authors?

Added myself cause I'll be an admin on the composer repo

composer.json Outdated Show resolved Hide resolved
@retlehs
Copy link
Member

retlehs commented Jun 9, 2019

@Foxaii is the original author, please add him to the list (at the 🔝)

@vinkla vinkla closed this Oct 21, 2019
@vinkla
Copy link
Collaborator Author

vinkla commented Oct 21, 2019

Closing due to inactivity.

@retlehs retlehs mentioned this pull request May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add composer.json and such
3 participants